FF-2525 Add Assignment Details to logger #106
Conversation
greghuels
force-pushed
the
greg/FF-2525/assignment-logger
branch
from
274704a
to
ba69a83
Compare
greghuels
force-pushed
the
greg/FF-2525/assignment-logger
branch
2 times, most recently
from
15287af
to
992e23c
Compare
| @@ -622,6 +622,7 @@ export default class EppoClient { | |||
| sdkLanguage: 'javascript', | |||
| sdkLibVersion: LIB_VERSION, | |||
| }, | |||
| details: result.flagEvaluationDetails, | |||
There was a problem hiding this comment.
🕵️♂️ Spotted the actual change! 😛
|
|
||
| import EppoClient, { | ||
| AssignmentDetails, |
There was a problem hiding this comment.
Guessing these were unused imports
| @@ -26,7 +26,7 @@ export interface AllocationEvaluation { | |||
| orderPosition: number; | |||
| } | |||
|
|
|||
| export interface FlagEvaluationDetails { | |||
| export interface IFlagEvaluationDetails { | |||
There was a problem hiding this comment.
Nice! Yes this is our naming convention for interfaces
| @@ -11,6 +12,22 @@ describe('IAssignmentEvent', () => { | |||
| timestamp: new Date().toISOString(), | |||
| subjectAttributes: { age: 25, country: 'USA' }, | |||
| holdoutKey: 'holdout_key_123', | |||
| details: { | |||
There was a problem hiding this comment.
The purpose of this test was not obvious to me until I ran it myself. It will fail if any required attribute in IAssignmentEvent is missing but will pass if attributes not specified in IAssignmentEvent are included in the event object (the latter behavior is described by the test "it" statement)
Just a suggestion (feel free to take it or leave it): if it's not too much trouble, you could add a test that checks for a thrown exception if details (a required attribute in the event object) is missing
greghuels
force-pushed
the
greg/FF-2525/assignment-logger
branch
from
992e23c
to
7793a4c
Compare
Implements FF-2465
Motivation and Context
Most people who are using the assignment logger are doing it to gain more insight on the assignments. It makes sense to include the "details" as well so that they have access to all the information available.
Description
Added "details" to assignment, cleaned up imports, and renamed interfaces to follow convention.